[
https://issues.apache.org/jira/browse/HBASE-19702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16314547#comment-16314547
]
Xiang Li edited comment on HBASE-19702 at 1/6/18 1:01 PM:
----------------------------------------------------------
[~chia7712], [~appy] Thanks for the comments.
Patch 000 is uploaded. One more change is made: I am not sure why in
{code}
public RSGroupInfo(RSGroupInfo src) {
this(src.getName(), src.servers, src.tables);
}
{code}
The fields of servers and tables are read from src directly, but name is read
by getXXX method. So I made them unified.
was (Author: water):
[~chia7712] [~appy] Thanks for the comments.
Patch 000 is uploaded. One more change is made: I am not sure why in
{code}
public RSGroupInfo(RSGroupInfo src) {
this(src.getName(), src.servers, src.tables);
}
{code}
The fields of servers and tables are read from src directly, but name is read
by getXXX method. So I made them unified.
> Improve RSGroupInfo constructors
> --------------------------------
>
> Key: HBASE-19702
> URL: https://issues.apache.org/jira/browse/HBASE-19702
> Project: HBase
> Issue Type: Improvement
> Reporter: Xiang Li
> Assignee: Xiang Li
> Priority: Minor
> Fix For: 2.0.0-beta-2
>
>
> {code:title=hbase-common/src/main/java/org/apache/hadoop/hbase/rsgroup/RSGroupInfo.java|borderStyle=solid}
> RSGroupInfo(String name, SortedSet<Address> servers, SortedSet<TableName>
> tables) {
> this.name = name;
> this.servers = servers == null? new TreeSet<>(): servers;
> this.servers.addAll(servers);
> this.tables = new TreeSet<>(tables);
> }
> {code}
> 2 improvements could be made:
> * When servers is not null, addAll(servers) tries to add all items in servers
> again. Seems not needed
> * new TreeSet<>(tables) has no null check on tables. The constructor of
> TreeSet does not do the null check either. It leads to NullPointerException
> if tables is null
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
