[
https://issues.apache.org/jira/browse/HBASE-19633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16317774#comment-16317774
]
Hudson commented on HBASE-19633:
--------------------------------
FAILURE: Integrated in Jenkins build HBase-Trunk_matrix #4367 (See
[https://builds.apache.org/job/HBase-Trunk_matrix/4367/])
HBASE-19633 Clean up the replication queues in the postPeerModification
(zhangduo: rev 19707a85dd3287ccd2dc9f70a3a437ece7352722)
* (edit)
hbase-server/src/main/java/org/apache/hadoop/hbase/master/replication/RemovePeerProcedure.java
* (edit)
hbase-replication/src/main/java/org/apache/hadoop/hbase/replication/ReplicationPeers.java
* (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java
* (edit)
hbase-server/src/main/java/org/apache/hadoop/hbase/master/replication/DisablePeerProcedure.java
* (edit)
hbase-server/src/main/java/org/apache/hadoop/hbase/master/replication/EnablePeerProcedure.java
* (edit)
hbase-server/src/main/java/org/apache/hadoop/hbase/master/replication/AddPeerProcedure.java
* (edit)
hbase-replication/src/main/java/org/apache/hadoop/hbase/replication/ZKReplicationQueueStorage.java
* (edit)
hbase-mapreduce/src/main/java/org/apache/hadoop/hbase/mapreduce/replication/VerifyReplication.java
* (edit)
hbase-server/src/main/java/org/apache/hadoop/hbase/master/replication/ModifyPeerProcedure.java
* (edit)
hbase-server/src/main/java/org/apache/hadoop/hbase/master/replication/UpdatePeerConfigProcedure.java
* (edit)
hbase-server/src/main/java/org/apache/hadoop/hbase/master/replication/RefreshPeerProcedure.java
* (edit)
hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/RefreshPeerCallable.java
* (edit)
hbase-client/src/main/java/org/apache/hadoop/hbase/replication/ReplicationPeerConfig.java
* (edit)
hbase-server/src/test/java/org/apache/hadoop/hbase/client/replication/TestReplicationAdminUsingProcedure.java
* (edit)
hbase-server/src/main/java/org/apache/hadoop/hbase/master/replication/ReplicationPeerManager.java
* (edit)
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
* (edit)
hbase-replication/src/main/java/org/apache/hadoop/hbase/replication/ZKReplicationStorageBase.java
* (edit)
hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSourceManager.java
* (edit)
hbase-replication/src/test/java/org/apache/hadoop/hbase/replication/TestReplicationStateBasic.java
* (edit)
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RemoteProcedureResultReporter.java
> Clean up the replication queues in the postPeerModification stage when
> removing a peer
> --------------------------------------------------------------------------------------
>
> Key: HBASE-19633
> URL: https://issues.apache.org/jira/browse/HBASE-19633
> Project: HBase
> Issue Type: Sub-task
> Components: proc-v2, Replication
> Reporter: Duo Zhang
> Assignee: Duo Zhang
> Fix For: 3.0.0
>
> Attachments: HBASE-19633-HBASE-19397-v1.patch,
> HBASE-19633-HBASE-19397-v2.patch, HBASE-19633-HBASE-19397-v3.patch,
> HBASE-19633-HBASE-19397.patch
>
>
> In the previous implementation, we can not always cleanly remove all the
> replication queues when removing a peer since the removing work is done by RS
> and if an RS is crashed then some queues may left there forever. That's why
> we need to check if there are already some queues for a newly created peer
> since we may reuse the peer id and causes problem.
> With the new procedure based replication peer modification, I think we can do
> it cleanly. After the RefreshPeerProcedures are done on all RSes, we can make
> sure that no RS will create queue for this peer again, then we can iterate
> over all the queues for all Rses and do another round of clean up.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
