[ 
https://issues.apache.org/jira/browse/HBASE-11409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16319827#comment-16319827
 ] 

stack commented on HBASE-11409:
-------------------------------

[~churromorales] I'd be fine w/ it going into a beta-2.

Few comments on patch Sir....

You have to use our internal shaded guava rather than guava directly:

21      import com.google.common.collect.Lists;
22      import com.google.common.collect.Maps;

Do import org.apache.hadoop.hbase.shaded.com.google..... or some such. Our 
internal guava is 0.23 or something. The unshaded is guava 0.12 or so.

Otherwise patch seems fine. You tested it? Add a release note. Thanks 
[~churromorales].



> Add more flexibility for input directory structure to LoadIncrementalHFiles
> ---------------------------------------------------------------------------
>
>                 Key: HBASE-11409
>                 URL: https://issues.apache.org/jira/browse/HBASE-11409
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 3.0.0
>            Reporter: churro morales
>            Assignee: churro morales
>             Fix For: 2.0.0-beta-2
>
>         Attachments: HBASE-11409.v1.patch, HBASE-11409.v2.patch, 
> HBASE-11409.v3.patch
>
>
> Use case:
> We were trying to combine two very large tables into a single table.  Thus we 
> ran jobs in one datacenter that populated certain column families and another 
> datacenter which populated other column families.  Took a snapshot and 
> exported them to their respective datacenters.  Wanted to simply take the 
> hdfs restored snapshot and use LoadIncremental to merge the data.  
> It would be nice to add support where we could run LoadIncremental on a 
> directory where the depth of store files is something other than two (current 
> behavior).  
> With snapshots it would be nice if you could pass a restored hdfs snapshot's 
> directory and have the tool run.  
> I am attaching a patch where I parameterize the bulkLoad timeout as well as 
> the default store file depth.  



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to