[
https://issues.apache.org/jira/browse/HBASE-19749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16319956#comment-16319956
]
Zheng Hu edited comment on HBASE-19749 at 1/10/18 9:33 AM:
-----------------------------------------------------------
Found a better way to test point#2 : As long as the UserScanQueryMatcher
returns SEEK_NEXT_COL or INCLUDE_AND_SEEK_NEXT_COL,
UserScanQueryMatcher#getKeyForNextColumn should return an cell whose column is
larger than the current cell's .
was (Author: openinx):
Found a better way to test : As long as the UserScanQueryMatcher returns
SEEK_NEXT_COL or INCLUDE_AND_SEEK_NEXT_COL,
UserScanQueryMatcher#getKeyForNextColumn should return an cell whose column is
larger than the current cell's .
> Revisit logic of UserScanQueryMatcher#mergeFilterResponse method
> -----------------------------------------------------------------
>
> Key: HBASE-19749
> URL: https://issues.apache.org/jira/browse/HBASE-19749
> Project: HBase
> Issue Type: Bug
> Reporter: Zheng Hu
> Assignee: Zheng Hu
>
> As HBASE-19729 comment , there are following points to be optimized:
> 1. when the number of cells exceed max version in scan, we should return
> SEEK_NEXT_COL match code, but if current code is INCLUDE_AND_SEEK_NEXT_ROW,
> we can optimize to choose the max step between SEEK_NEXT_COL and
> INCLUDE_AND_SEEK_NEXT_ROW, which is SEEK_NEXT_ROW
> 2. check to call ColumnTracker#doneWithColumn() only when we change the
> match code to SEEK_NEXT_COL or INCLUDE_AND_SEEK_NEXT_COL because of
> filterResponse.
> 3. More UT for those edge case..
> https://issues.apache.org/jira/browse/HBASE-19729?focusedCommentId=16318131&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16318131
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
