[ 
https://issues.apache.org/jira/browse/HBASE-19752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16320812#comment-16320812
 ] 

Mike Drob commented on HBASE-19752:
-----------------------------------

bq. +        LOG.debug("There is no assigned server for " + region);
use parameterized logging here

bq. +        LOG.debug("Couldn't obtain rs group information");
include info about which rsgroup/server/region (whatever makes sense)

> RSGroupBasedLoadBalancer#getMisplacedRegions() should handle the case where 
> rs group cannot be determined
> ---------------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-19752
>                 URL: https://issues.apache.org/jira/browse/HBASE-19752
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Ted Yu
>            Assignee: Ted Yu
>         Attachments: 19752.v1.txt, 19752.v2.txt, 19752.v3.txt
>
>
> Observed the following in rs group test output:
> {code}
> 2018-01-10 14:17:23,006 DEBUG [AssignmentThread] 
> rsgroup.RSGroupBasedLoadBalancer(316): Found misplaced region: 
> hbase:acl,,1515593841277.ecf47ecb7522d7fab40db0a237f973fd. on server: 
> localhost,1,1 found in group: null outside of group: UNKNOWN
> {code}
> Here is corresponding code:
> {code}
>       if (assignedServer != null &&
>           (info == null || 
> !info.containsServer(assignedServer.getAddress()))) {
>         RSGroupInfo otherInfo = null;
>         otherInfo = 
> rsGroupInfoManager.getRSGroupOfServer(assignedServer.getAddress());
>         LOG.debug("Found misplaced region: " + 
> regionInfo.getRegionNameAsString() +
> {code}
> As you can see, both info and otherInfo were null.
> In this case, the region should not be placed in misplacedRegions.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to