[
https://issues.apache.org/jira/browse/HBASE-19746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16321661#comment-16321661
]
Chia-Ping Tsai commented on HBASE-19746:
----------------------------------------
Thanks to [~sergey.soldatov] for the great input. I do the similar jmh and then
get the similar result.
bq. We'll be doing KeyValue#getType under the covers, right? This default
Cell#getType won't be used (perhaps in tests/mockito?).
Currently, Cell#getType isn't used in production. But ProtobufUtil should use
it to replace the {{getTypeByte}} since the getTypeByte will be removed.
Will add a small cache to speed up the seek in next patch.
> Add default impl to Cell#getType
> --------------------------------
>
> Key: HBASE-19746
> URL: https://issues.apache.org/jira/browse/HBASE-19746
> Project: HBase
> Issue Type: Sub-task
> Reporter: Chia-Ping Tsai
> Assignee: Chia-Ping Tsai
> Priority: Critical
> Fix For: 2.0.0
>
> Attachments: HBASE-19746.v0.patch
>
>
> Noticed this issue when migrating the app to branch-2.
> {{Cell}} is IA.Public so it should obey our compatibility rules. Not sure
> whether any related discussion had be in HBASE-19112. It worthwhile, however,
> to raise this issue again.
> FYI [~anoopsamjohn] [~ram_krish] [~stack]
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
