[
https://issues.apache.org/jira/browse/HBASE-19083?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16321903#comment-16321903
]
Zheng Hu commented on HBASE-19083:
----------------------------------
#1 the create method look strange, Can define as create(Mode mode,
AsyncWriter... writers ) directly ?
{code}
+ public static CombinedAsyncWriter create(Mode mode, AsyncWriter writer,
AsyncWriter... writers) {
+ ImmutableList<AsyncWriter> ws =
+ ImmutableList.<AsyncWriter> builder().add(writer).add(writers).build();
+ switch (mode) {
{code}
#2 Still the create() method in CombinedAsyncWriter.java . when mode is
SEQUENTIAL, the CompletableFuture<long> will be filled with a null, but when
mode is PARALLEL, it will be filled with the sync size of the last finised
writer. so , what's the specific meaning of Long value you want to return ?
Will appreciate if put patch on RB .
> Introduce a new log writer which can write to two HDFSes
> --------------------------------------------------------
>
> Key: HBASE-19083
> URL: https://issues.apache.org/jira/browse/HBASE-19083
> Project: HBase
> Issue Type: Sub-task
> Components: Replication, wal
> Reporter: Duo Zhang
> Assignee: Duo Zhang
> Labels: HBASE-19064
> Fix For: HBASE-19064
>
> Attachments: HBASE-19083.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
