[
https://issues.apache.org/jira/browse/HBASE-19780?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16329333#comment-16329333
]
Appy commented on HBASE-19780:
------------------------------
bq. If we do it that way we should add a short hint in the documentation that
mvn checkstyle:checkstyle needs to work locally before submitting a patch ...
Can add "Submitting Patches" section in documentation. Was trying it locally
first, added a checkstyle error to ForeignExceptionUtil and ran {{mvn
checkstyle:checkstyle}}, but the command didn't fail (with patch 003 above).
bq. ...and that committers should pay attention to that point in the pre-commit
job.
New checkstyle warnings will show up as +/- 1 in hadoop QA result. So that's
covered.
bq. If we do it that way it isn't necessary to define Checkstyle in the
sub-modules, as long as the plugin is configured in the top-level POM.
If we remove checkstyle definitions from sub-modules, we'll loose the nice
failOnViolation things that you have added to prevent regressions. They are
great! I'd like to keep them.
Here's a suggestion building on your previous one:
# Let's add a recommendation in documentation that run {{mvn checkstyle:check}}
before submitting patches since it'll catch CS violations in modules which are
perfectly clean.
# Add {{checkstyle:check}} as part of main pre-commit build. If there is any
violation in these clean modules (towards which you have put great effort),
then the pre-commit will fail also for the mvn install step, which is an
important one. Thus, clean CK in these modules become hard pre-commit
requirement *indirectly*.
If you agree, let's put a note on dev@ proposing these changes.
In meantime, does 003 (002 + fixing bad pom) seem good to you for committing ?
> Change execution phase of checkstyle plugin back to default 'verify'
> --------------------------------------------------------------------
>
> Key: HBASE-19780
> URL: https://issues.apache.org/jira/browse/HBASE-19780
> Project: HBase
> Issue Type: Bug
> Reporter: Appy
> Assignee: Appy
> Priority: Major
> Attachments: HBASE-19780.master.001.patch,
> HBASE-19780.master.002.patch
>
>
> Not able to run following command successfully:
> {{mvn -DskipTests install site
> -Dmaven.repo.local=/Users/appy/Desktop/temp_repo}}
> Use a clean separate repo so that existing packages don't pollute the build.
> Error is following.
> {noformat}
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-site-plugin:3.4:site (default-site) on project
> hbase: failed to get report for
> org.apache.maven.plugins:maven-javadoc-plugin: Failed to execute goal
> org.apache.maven.plugins:maven-checkstyle-plugin:2.17:check (checkstyle) on
> project hbase-error-prone: Execution checkstyle of goal
> org.apache.maven.plugins:maven-checkstyle-plugin:2.17:check failed: Plugin
> org.apache.maven.plugins:maven-checkstyle-plugin:2.17 or one of its
> dependencies could not be resolved: Failure to find
> org.apache.hbase:hbase-checkstyle:jar:2.0.0-beta-1 in
> http://repository.apache.org/snapshots/ was cached in the local repository,
> resolution will not be reattempted until the update interval of
> apache.snapshots has elapsed or updates are forced -> [Help 1]
> {noformat}
> Note that master build goes pass this point.
> Need to figure out what's the difference and fix the overall build.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
