[
https://issues.apache.org/jira/browse/HBASE-5229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13201624#comment-13201624
]
[email protected] commented on HBASE-5229:
------------------------------------------------------
bq. On 2012-02-06 20:24:17, Ted Yu wrote:
bq. >
http://svn.apache.org/repos/asf/hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java,
line 4152
bq. > <https://reviews.apache.org/r/3748/diff/3/?file=72610#file72610line4152>
bq. >
bq. > What if rm contains more than one Mutation ?
Hopefully rm does contain more than one Mutation, otherwise using this API is
pointless. :)
It is guranteed, though, that all Mutations are for this single row.
Do you see a concern?
bq. On 2012-02-06 20:24:17, Ted Yu wrote:
bq. >
http://svn.apache.org/repos/asf/hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java,
line 4171
bq. > <https://reviews.apache.org/r/3748/diff/3/?file=72610#file72610line4171>
bq. >
bq. > else is not needed considering exception is thrown on line 4170.
Right. But this makes the flow clear. Personally I am not a big fan of having
to look through code and having to piece together the control flow by tracking
exceptions and return statements.
I don't mind changing it, though.
- Lars
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3748/#review4844
-----------------------------------------------------------
On 2012-02-06 19:51:58, Lars Hofhansl wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/3748/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-02-06 19:51:58)
bq.
bq.
bq. Review request for hbase.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. This builds on HBASE-3584, HBASE-5203, and HBASE-5304.
bq.
bq. Multiple Rows can be locked and applied atomically as long as the
application ensures that all rows reside in the same Region (by presplitting or
a custom RegionSplitPolicy).
bq. At SFDC we can use this to colocate subsets of a tenant's data and allow
atomic operations over these subsets.
bq.
bq. Obviously this is an advanced features and this prominently called out in
the Javadoc.
bq.
bq.
bq. This addresses bug HBASE-5229.
bq. https://issues.apache.org/jira/browse/HBASE-5229
bq.
bq.
bq. Diffs
bq. -----
bq.
bq.
http://svn.apache.org/repos/asf/hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
1241120
bq.
http://svn.apache.org/repos/asf/hbase/trunk/src/main/java/org/apache/hadoop/hbase/rest/client/RemoteHTable.java
1241120
bq.
http://svn.apache.org/repos/asf/hbase/trunk/src/test/java/org/apache/hadoop/hbase/client/TestFromClientSide.java
1241120
bq.
http://svn.apache.org/repos/asf/hbase/trunk/src/test/java/org/apache/hadoop/hbase/regionserver/TestAtomicOperation.java
1241120
bq.
http://svn.apache.org/repos/asf/hbase/trunk/src/main/java/org/apache/hadoop/hbase/io/HbaseObjectWritable.java
1241120
bq.
http://svn.apache.org/repos/asf/hbase/trunk/src/main/java/org/apache/hadoop/hbase/ipc/HRegionInterface.java
1241120
bq.
http://svn.apache.org/repos/asf/hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
1241120
bq.
http://svn.apache.org/repos/asf/hbase/trunk/src/main/java/org/apache/hadoop/hbase/client/MultiRowMutation.java
PRE-CREATION
bq.
http://svn.apache.org/repos/asf/hbase/trunk/src/main/java/org/apache/hadoop/hbase/coprocessor/CoprocessorHost.java
1241120
bq.
http://svn.apache.org/repos/asf/hbase/trunk/src/main/java/org/apache/hadoop/hbase/client/HTable.java
1241120
bq.
http://svn.apache.org/repos/asf/hbase/trunk/src/main/java/org/apache/hadoop/hbase/client/HTableInterface.java
1241120
bq.
bq. Diff: https://reviews.apache.org/r/3748/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Tests added to TestFromClientSide and TestAtomicOperation
bq.
bq.
bq. Thanks,
bq.
bq. Lars
bq.
bq.
> Explore building blocks for "multi-row" local transactions.
> -----------------------------------------------------------
>
> Key: HBASE-5229
> URL: https://issues.apache.org/jira/browse/HBASE-5229
> Project: HBase
> Issue Type: New Feature
> Components: client, regionserver
> Reporter: Lars Hofhansl
> Assignee: Lars Hofhansl
> Fix For: 0.94.0
>
> Attachments: 5229-multiRow-v2.txt, 5229-multiRow.txt,
> 5229-seekto-v2.txt, 5229-seekto.txt, 5229.txt
>
>
> HBase should provide basic building blocks for multi-row local transactions.
> Local means that we do this by co-locating the data. Global (cross region)
> transactions are not discussed here.
> After a bit of discussion two solutions have emerged:
> 1. Keep the row-key for determining grouping and location and allow efficient
> intra-row scanning. A client application would then model tables as
> HBase-rows.
> 2. Define a prefix-length in HTableDescriptor that defines a grouping of
> rows. Regions will then never be split inside a grouping prefix.
> #1 is true to the current storage paradigm of HBase.
> #2 is true to the current client side API.
> I will explore these two with sample patches here.
> --------------------
> Was:
> As discussed (at length) on the dev mailing list with the HBASE-3584 and
> HBASE-5203 committed, supporting atomic cross row transactions within a
> region becomes simple.
> I am aware of the hesitation about the usefulness of this feature, but we
> have to start somewhere.
> Let's use this jira for discussion, I'll attach a patch (with tests)
> momentarily to make this concrete.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
