[
https://issues.apache.org/jira/browse/HBASE-5074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13201988#comment-13201988
]
Phabricator commented on HBASE-5074:
------------------------------------
dhruba has commented on the revision "[jira] [HBASE-5074] Support checksums in
HBase block cache".
INLINE COMMENTS
src/main/java/org/apache/hadoop/hbase/io/hfile/HFileBlock.java:287 can you pl
elaborate more on this comment?
src/test/java/org/apache/hadoop/hbase/io/hfile/TestHFileBlockCompatibility.java:76
I think it is better to keep the compatibility code separate from existing
live-test code. That way, it is guaranteed to never change.
is there any other existing unit test that keeps a version1 file to run unit
tests against?
src/test/java/org/apache/hadoop/hbase/io/hfile/TestHFileBlockCompatibility.java:365
I did not strip it down, just so that it remains as it was earlier. This is
for backward-compatibility, so isn't it better to keep as it was?
src/test/java/org/apache/hadoop/hbase/io/hfile/TestHFileBlockCompatibility.java:800
Was useful while testing, but I will get rid of it.
REVISION DETAIL
https://reviews.facebook.net/D1521
> support checksums in HBase block cache
> --------------------------------------
>
> Key: HBASE-5074
> URL: https://issues.apache.org/jira/browse/HBASE-5074
> Project: HBase
> Issue Type: Improvement
> Components: regionserver
> Reporter: dhruba borthakur
> Assignee: dhruba borthakur
> Attachments: D1521.1.patch, D1521.1.patch, D1521.2.patch,
> D1521.2.patch, D1521.3.patch, D1521.3.patch
>
>
> The current implementation of HDFS stores the data in one block file and the
> metadata(checksum) in another block file. This means that every read into the
> HBase block cache actually consumes two disk iops, one to the datafile and
> one to the checksum file. This is a major problem for scaling HBase, because
> HBase is usually bottlenecked on the number of random disk iops that the
> storage-hardware offers.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
