[ 
https://issues.apache.org/jira/browse/HBASE-19658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16342592#comment-16342592
 ] 

Anastasia Braginsky commented on HBASE-19658:
---------------------------------------------

Hey,

I have taken a look on the RB and the fix looks good to me. Just one thing I 
would suggest, is to add a comment in TestCompactingToCellFlatMapMemStore.java 
line about 810 explaining what is it checked there and why. Generally, I would 
like someone else to take an additional look before we commit. [~anoop.hbase], 
[~ram_krish] would you like to take a look?

> Fix and reenable 
> TestCompactingToCellFlatMapMemStore#testFlatteningToJumboCellChunkMap
> --------------------------------------------------------------------------------------
>
>                 Key: HBASE-19658
>                 URL: https://issues.apache.org/jira/browse/HBASE-19658
>             Project: HBase
>          Issue Type: Bug
>          Components: test
>    Affects Versions: 2.0.0-beta-1
>            Reporter: stack
>            Assignee: Anastasia Braginsky
>            Priority: Major
>             Fix For: 2.0.0-beta-2
>
>         Attachments: HBASE-19658-V01.patch, HBASE-19658-V02.patch, 
> HBASE-19658-V03.patch, HBASE-19658-V04.patch, HBASE-19658-V05.patch, 
> HBASE-19658.05.patch, 
> org.apache.hadoop.hbase.regionserver.TestCompactingToCellFlatMapMemStore-output.txt
>
>
> testFlatteningToJumboCellChunkMap was disabled so could commit HBASE-19282 on 
> branch-2. This test is failing reliably. Assigned to [~anastas]. This issue 
> is about fixing the failing test and reenabling it in time for beta-2. Thanks 
> A.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to