[ 
https://issues.apache.org/jira/browse/HBASE-5345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13202737#comment-13202737
 ] 

Hadoop QA commented on HBASE-5345:
----------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12513666/5345-v2.txt
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 3 new or modified tests.

    -1 javadoc.  The javadoc tool appears to have generated -136 warning 
messages.

    +1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

    -1 findbugs.  The patch appears to introduce 156 new Findbugs (version 
1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

     -1 core tests.  The patch failed these unit tests:
                       org.apache.hadoop.hbase.io.hfile.TestHFileBlock
                  org.apache.hadoop.hbase.mapreduce.TestImportTsv
                  org.apache.hadoop.hbase.mapred.TestTableMapReduce
                  org.apache.hadoop.hbase.mapreduce.TestHFileOutputFormat

Test results: 
https://builds.apache.org/job/PreCommit-HBASE-Build/913//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/913//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/913//console

This message is automatically generated.
                
> CheckAndPut doesn't work when value is empty byte[]
> ---------------------------------------------------
>
>                 Key: HBASE-5345
>                 URL: https://issues.apache.org/jira/browse/HBASE-5345
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 0.92.0
>            Reporter: Evert Arckens
>            Assignee: Evert Arckens
>             Fix For: 0.94.0, 0.92.1
>
>         Attachments: 5345-v2.txt, 5345.txt, 
> checkAndMutateEmpty-HBASE-5345.patch
>
>
> When a value contains an empty byte[] and then a checkAndPut is performed 
> with an empty byte[] , the operation will fail.
> For example:
> Put put = new Put(row1);
> put.add(fam1, qf1, new byte[0]);
> table.put(put);
> put = new Put(row1);
> put.add(fam1, qf1, val1);
> table.checkAndPut(row1, fam1, qf1, new byte[0], put); ---> false
> I think this is related to HBASE-3793 and HBASE-3468.
> Note that you will also get into this situation when first putting a null 
> value ( put.add(fam1,qf1,null) ), as this value will then be regarded and 
> returned as an empty byte[] upon a get.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to