[ 
https://issues.apache.org/jira/browse/HBASE-19887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16344554#comment-16344554
 ] 

Duo Zhang commented on HBASE-19887:
-----------------------------------

OK, the problem is the same with hbase-common in HBASE-19873. We define a 
listener in hbase-server/pom.xml and overwrite the default listener in the 
parent pom.xml.

{noformat}
            <property>
              <name>listener</name>
              
<value>org.apache.hadoop.hbase.ServerResourceCheckerJUnitListener</value>
            </property>
{noformat}

Looked at the code, there is no difference between 
ServerResourceCheckerJUnitListener and ResourceCheckerJUnitListener?

{code}
/**
 * Monitor the resources. use by the tests All resources in {@link 
ResourceCheckerJUnitListener}
 *  plus the number of connection.
 */
public class ServerResourceCheckerJUnitListener extends 
ResourceCheckerJUnitListener {
}
{code}

Although the comments said that we have an extra number of connection check but 
seems not.

In general I prefer we set the listener in the parent pom.xml. What do you 
think [~stack].

Thanks.

> Find out why the HBaseClassTestRuleCheck does not work in pre commit
> --------------------------------------------------------------------
>
>                 Key: HBASE-19887
>                 URL: https://issues.apache.org/jira/browse/HBASE-19887
>             Project: HBase
>          Issue Type: Sub-task
>          Components: build
>            Reporter: Duo Zhang
>            Assignee: Duo Zhang
>            Priority: Major
>         Attachments: HBASE-19887.patch
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to