[
https://issues.apache.org/jira/browse/HBASE-19898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16347042#comment-16347042
]
Chia-Ping Tsai commented on HBASE-19898:
----------------------------------------
If user enable the {{writeSniffing}} only, it won't work since the sink is ofÂ
RegionServerStdOutSink? If so, the patch LGTM since the config
{{hbase.canary.sink.class}} isn't in our docs. Could you add the test for your
fix?
> Canary should choose RegionStdOutSink automatically when write sniffing is
> specified
> ------------------------------------------------------------------------------------
>
> Key: HBASE-19898
> URL: https://issues.apache.org/jira/browse/HBASE-19898
> Project: HBase
> Issue Type: Bug
> Reporter: Ted Yu
> Assignee: Ted Yu
> Priority: Trivial
> Attachments: 19898.v1.txt, 19898.v1.txt
>
>
> Currently RegionServerStdOutSink is instantiated by default, even if user
> specifies -writeSniffing on the command line.
> Write sniffing would be ignored since Sink instance is of
> RegionServerStdOutSink class:
> {code}
> if (this.sink instanceof RegionServerStdOutSink || this.regionServerMode)
> {
> monitor =
> new RegionServerMonitor(connection, monitorTargets, this.useRegExp,
> (StdOutSink) this.sink, this.executor,
> this.regionServerAllRegions,
> this.treatFailureAsError);
> {code}
> RegionStdOutSink should be used for write sniffing.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
