[ 
https://issues.apache.org/jira/browse/HBASE-19884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16348611#comment-16348611
 ] 

Chia-Ping Tsai commented on HBASE-19884:
----------------------------------------

We should also remove the {{compareTo}} from {{BucketEntryGroup}}, and then add 
the {{Comparator<BucketEntryGroup>}} to the {{PriorityQueue}}. Otherwise, the 
inconsistency between {{compareTo()== 0}} and {{equals()}}still exists even if 
we remove the impl of {{equals()}} and {{hashCode()}};

> BucketEntryGroup's equals, hashCode and compareTo methods are not consistent
> ----------------------------------------------------------------------------
>
>                 Key: HBASE-19884
>                 URL: https://issues.apache.org/jira/browse/HBASE-19884
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 2.0.0-beta-1
>            Reporter: Peter Somogyi
>            Assignee: Peter Somogyi
>            Priority: Major
>             Fix For: 2.0.0-beta-2
>
>         Attachments: HBASE-19884.master.001.patch, 
> HBASE-19884.master.001.patch, HBASE-19884.master.001.patch, 
> HBASE-19884.master.002.patch
>
>
> BucketEntryGroup currently uses different fields to calculate compareTo, 
> equals and hasCode.
> In some cases !a.equals(b) but a.compareTo(b) == 0. Javadoc of Comparator 
> recommends that natural orderings be consistent with equals.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to