[
https://issues.apache.org/jira/browse/HBASE-5074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13202988#comment-13202988
]
Phabricator commented on HBASE-5074:
------------------------------------
tedyu has commented on the revision "[jira] [HBASE-5074] Support checksums in
HBase block cache".
INLINE COMMENTS
src/main/java/org/apache/hadoop/hbase/util/ChecksumType.java:64 Constants are
normally spelled in upper cases.
src/main/java/org/apache/hadoop/hbase/util/ChecksumType.java:66 Should this
be lifted to line 38 ?
src/main/java/org/apache/hadoop/hbase/util/ChecksumType.java:73 e should be
included in message.
src/main/java/org/apache/hadoop/hbase/util/ChecksumType.java:111 We should
share the LOG with CRC32.
src/main/java/org/apache/hadoop/hbase/util/HFileSystem.java:2 Year is not
needed.
src/main/java/org/apache/hadoop/hbase/util/ChecksumByteArrayOutputStream.java:2
Year is not needed.
src/test/java/org/apache/hadoop/hbase/io/hfile/TestChecksum.java:2 Year is
not needed.
REVISION DETAIL
https://reviews.facebook.net/D1521
> support checksums in HBase block cache
> --------------------------------------
>
> Key: HBASE-5074
> URL: https://issues.apache.org/jira/browse/HBASE-5074
> Project: HBase
> Issue Type: Improvement
> Components: regionserver
> Reporter: dhruba borthakur
> Assignee: dhruba borthakur
> Attachments: D1521.1.patch, D1521.1.patch, D1521.2.patch,
> D1521.2.patch, D1521.3.patch, D1521.3.patch, D1521.4.patch, D1521.4.patch
>
>
> The current implementation of HDFS stores the data in one block file and the
> metadata(checksum) in another block file. This means that every read into the
> HBase block cache actually consumes two disk iops, one to the datafile and
> one to the checksum file. This is a major problem for scaling HBase, because
> HBase is usually bottlenecked on the number of random disk iops that the
> storage-hardware offers.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
