[
https://issues.apache.org/jira/browse/HBASE-19858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16348860#comment-16348860
]
Abhishek Singh Chouhan commented on HBASE-19858:
------------------------------------------------
In StoreFile.java we might want to add default value too, else we might end up
passing null to setStoragePolicy :
{noformat}
if (null == policyName) {
- policyName = this.conf.get(HStore.BLOCK_STORAGE_POLICY_KEY);
+ policyName = this.conf.get(HStore.BLOCK_STORAGE_POLICY_KEY,
HStore.DEFAULT_BLOCK_STORAGE_POLICY)
}{noformat}
Rest LGTM.
> Backport HBASE-14061 (Support CF-level Storage Policy) to branch-1
> ------------------------------------------------------------------
>
> Key: HBASE-19858
> URL: https://issues.apache.org/jira/browse/HBASE-19858
> Project: HBase
> Issue Type: Task
> Reporter: Andrew Purtell
> Assignee: Andrew Purtell
> Priority: Major
> Fix For: 1.5.0
>
> Attachments: HBASE-19858-branch-1.patch
>
>
> Backport the following commits to branch-1:
> * HBASE-14061 Support CF-level Storage Policy
> * HBASE-14061 Support CF-level Storage Policy (addendum)
> * HBASE-14061 Support CF-level Storage Policy (addendum2)
> * HBASE-15172 Support setting storage policy in bulkload
> * HBASE-17538 HDFS.setStoragePolicy() logs errors on local fs
> * HBASE-18015 Storage class aware block placement for procedure v2 WALs
> * HBASE-18017 Reduce frequency of setStoragePolicy failure warnings
> * HBASE-19016 Coordinate storage policy property name for table schema and
> bulkload
>
> Fix
> * Default storage policy if not configured cannot be "NONE"
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
