[
https://issues.apache.org/jira/browse/HBASE-19920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16351430#comment-16351430
]
Ted Yu commented on HBASE-19920:
--------------------------------
{code}
34 * @return Exception wrapped in ServiceException or
35 * a new IOException that wraps the unexpected ServiceException.
36 */
37 public static IOException
getRemoteException(com.google.protobuf.ServiceException se) {
{code}
For @return, IOException is returned.
{code}
61 * @param e
62 */
63 public static IOException handleRemoteException(Exception e) {
{code}
Add comment for @param
Are you going to add a test case in next patch ?
Please check unit test failure.
> TokenUtil.obtainToken unnecessarily creates a local directory
> -------------------------------------------------------------
>
> Key: HBASE-19920
> URL: https://issues.apache.org/jira/browse/HBASE-19920
> Project: HBase
> Issue Type: Bug
> Reporter: Rohini Palaniswamy
> Assignee: Mike Drob
> Priority: Major
> Fix For: 2.0
>
> Attachments: HBASE-19920.patch
>
>
> On client code, when one calls TokenUtil.obtainToken it loads ProtobufUtil
> which in its static block initializes DynamicClassLoader and that creates the
> directory ${hbase.local.dir}/jars/ and also instantiates a filesystem class
> to access hbase.dynamic.jars.dir.
> https://github.com/apache/hbase/blob/master/hbase-common/src/main/java/org/apache/hadoop/hbase/util/DynamicClassLoader.java#L109-L127
> Since this is region server specific code, not expecting this to happen when
> one accesses hbase as a client.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
