[ 
https://issues.apache.org/jira/browse/HBASE-19922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16351821#comment-16351821
 ] 

Chia-Ping Tsai commented on HBASE-19922:
----------------------------------------

patch LGTM. run the hadoop check with patch locally - PASS. [~mdrob] WDYT?

> ProtobufUtils::PRIMITIVES is unused
> -----------------------------------
>
>                 Key: HBASE-19922
>                 URL: https://issues.apache.org/jira/browse/HBASE-19922
>             Project: HBase
>          Issue Type: Task
>          Components: Protobufs
>            Reporter: Mike Drob
>            Assignee: Mike Drob
>            Priority: Major
>             Fix For: 2.0
>
>         Attachments: HBASE-19922.patch
>
>
> It looks like ProtobufUtils::PRIMITIVES is never read in both the shaded and 
> non-shaded versions of the class. Is it safe to remove?
> https://github.com/apache/hbase/blob/master/hbase-client/src/main/java/org/apache/hadoop/hbase/protobuf/ProtobufUtil.java#L128
> We populate the map in a static initializer but never read any values from 
> it...



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to