[ 
https://issues.apache.org/jira/browse/HBASE-19835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16355671#comment-16355671
 ] 

Ted Yu commented on HBASE-19835:
--------------------------------

Aman:
I got the following when applying your patch:

error: patch failed: 
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HStore.java:2315
error: 
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HStore.java: 
patch does not apply
Patch failed at 0001 Use explicit casting to avoid side effects

Please rebase and add JIRA number in the subject.

> Make explicit casting of atleast one operand to final type
> ----------------------------------------------------------
>
>                 Key: HBASE-19835
>                 URL: https://issues.apache.org/jira/browse/HBASE-19835
>             Project: HBase
>          Issue Type: Bug
>          Components: hbase
>    Affects Versions: 3.0.0
>            Reporter: Aman Poonia
>            Assignee: Aman Poonia
>            Priority: Minor
>         Attachments: HBASE-19835.master.01.patch
>
>
> We have used 
> _long = int + int_ 
> at many places mostly wherever ClassSize.java variables are used for 
> calculation.
> Need to cast explicitly at-least one operand to final type(i.e. type the 
> result is intended to be casted).
>  
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to