Peter Somogyi commented on HBASE-19950:

Nice patch [~reidchan]!


A few nits:
 * Import order is incorrect in ColumnValueFilter: 
org.apache.hadoop.hbase.shaded needs to be at the bottom.
 * Typo in CVF line 114: fiter -> filter
 * Can you add a comment for CVF#compareValue about the return value? You have 
some in filterCell method but I think it would be good on the method as well.
 * You changed the import order in CompareFilter. Since you're already 
modifying there, can you also fix org.apache.hadoop.hbase.shaded imports?

> Introduce a ColumnValueFilter
> -----------------------------
>                 Key: HBASE-19950
>                 URL: https://issues.apache.org/jira/browse/HBASE-19950
>             Project: HBase
>          Issue Type: Improvement
>          Components: Filters
>            Reporter: Reid Chan
>            Assignee: Reid Chan
>            Priority: Minor
>         Attachments: HBASE-19950.master.001.patch, 
> HBASE-19950.master.002.patch
> Different from {{SingleColumnValueFilter}} which returns an entire row when 
> specified condition is matched, this new filter will return the matched cell 
> only. There're already some discussions in HBASE-19824.

This message was sent by Atlassian JIRA

Reply via email to