Ben Lau commented on HBASE-19989:

Hi Ted, thanks for the feedback, I'm not sure a comment will be helpful since 
it comes down to 'if the break is here the code below doesn't run, so the break 
is not here' but I have added a comment anyway and re-added the ZKLess 
split/merge tests that were removed in branch-1.  Let me know your thoughts, 

> READY_TO_MERGE and READY_TO_SPLIT do not update region state correctly
> ----------------------------------------------------------------------
>                 Key: HBASE-19989
>                 URL: https://issues.apache.org/jira/browse/HBASE-19989
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 1.3.1, 1.4.1
>            Reporter: Ben Lau
>            Assignee: Ben Lau
>            Priority: Major
>         Attachments: HBASE-19989.patch, HBASE-19989.patch
> Region state transitions do not work correctly for READY_TO_MERGE/SPLIT.  
> [~thiruvel] and I noticed this is due to break statements being in the wrong 
> place in AssignmentManager.  This allows a race condition for example in 
> which one of the regions being merged could be moved concurrently, resulting 
> in the merge transaction failing and then double assignment and/or dataloss.  
> This bug appears to only affect branch-1 (for example 1.3 and 1.4) and not 
> branch-2 as the relevant code in AM has since been rewritten.

This message was sent by Atlassian JIRA

Reply via email to