[
https://issues.apache.org/jira/browse/HBASE-5358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13204314#comment-13204314
]
[email protected] commented on HBASE-5358:
------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3811/#review4960
-----------------------------------------------------------
src/main/java/org/apache/hadoop/hbase/io/HbaseObjectWritable.java
<https://reviews.apache.org/r/3811/#comment10901>
We are changing what is on the line now when we serialize? All arrays now
serialize their type ahead of array length? In our public API what arrays will
this effect? Do you know? Does it require our upping the version on the
Interface that uses HBaseObjectWritable?
src/test/java/org/apache/hadoop/hbase/io/TestHbaseObjectWritable.java
<https://reviews.apache.org/r/3811/#comment10902>
Good
- Michael
On 2012-02-09 01:38:18, enis wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/3811/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-02-09 01:38:18)
bq.
bq.
bq. Review request for hbase.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. HBaseObjectWritable can encode Writable[]'s but, but cannot encode A[]
where A extends Writable. This becomes an issue for example when adding a
coprocessor method which takes A[] (see HBASE-5352).
bq.
bq.
bq. This addresses bug HBASE-5358.
bq. https://issues.apache.org/jira/browse/HBASE-5358
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. src/test/java/org/apache/hadoop/hbase/io/TestHbaseObjectWritable.java
78513ce
bq. src/main/java/org/apache/hadoop/hbase/io/HbaseObjectWritable.java
260f982
bq.
bq. Diff: https://reviews.apache.org/r/3811/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq.
bq. Thanks,
bq.
bq. enis
bq.
bq.
> HBaseObjectWritable should be able to serialize generic arrays not defined
> previously
> -------------------------------------------------------------------------------------
>
> Key: HBASE-5358
> URL: https://issues.apache.org/jira/browse/HBASE-5358
> Project: HBase
> Issue Type: Improvement
> Components: coprocessors, io
> Reporter: Enis Soztutar
> Assignee: Enis Soztutar
>
> HBaseObjectWritable can encode Writable[]'s but, but cannot encode A[] where
> A extends Writable. This becomes an issue for example when adding a
> coprocessor method which takes A[] (see HBASE-5352).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
