[ 
https://issues.apache.org/jira/browse/HBASE-19995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16364831#comment-16364831
 ] 

Ted Yu commented on HBASE-19995:
--------------------------------

+1

> Current Jetty 9 version in HBase master branch can memory leak under high 
> traffic
> ---------------------------------------------------------------------------------
>
>                 Key: HBASE-19995
>                 URL: https://issues.apache.org/jira/browse/HBASE-19995
>             Project: HBase
>          Issue Type: Bug
>          Components: REST
>    Affects Versions: 2.0
>            Reporter: Ben Lau
>            Priority: Major
>         Attachments: HBASE-19995.patch
>
>
> There is a memory-leak in Jetty 9 that manifests whenever you hit the call 
> queue limit in HBase REST.  The memory-leak leaks both on-heap and off-heap 
> objects permanently.  It happens because whenever the call queue for Jetty 
> server overflows, the task that is rejected runs a 'reject' method if it is a 
> Rejectable to do any cleanup. This clean up is necessary to for example close 
> the connection, deallocate any buffers, etc. Unfortunately, in Jetty 9, they 
> implemented the 'reject' / cleanup method of the SelectChannelEndpoint as a 
> non-blocking call that is not guaranteed to run.  This was later fixed in 
> Jetty 9.4 and later backported however the version of Jetty 9 pulled in HBase 
> for REST comes before this fix.  See 
> [https://github.com/eclipse/jetty.project/issues/1804] and 
> [https://github.com/apache/hbase/blob/master/pom.xml#L1416.]
> If we want to stay on 9.3.X we could update to 
> [9.3.22.v20171030|https://mvnrepository.com/artifact/org.eclipse.jetty/jetty-server/9.3.22.v20171030]
>  which is the latest version of 9.3.  Thoughts?



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to