[
https://issues.apache.org/jira/browse/HBASE-19400?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16368449#comment-16368449
]
Appy commented on HBASE-19400:
------------------------------
Debugged both the tests.
TestAccessController was failing because new references to TableAuthManager
from RSRpcServices weren't being released.
Added stop() method to AccessChecker to release the reference since it's the
one thats "owns" the reference.
For TestPriorityRpc, it was because zk was null for those tests. Updated patch
to handle that in a way that also makes sense for prod - create AccessChecker
instance only when authorization is enabled.
> Add missing security hooks for MasterService RPCs
> -------------------------------------------------
>
> Key: HBASE-19400
> URL: https://issues.apache.org/jira/browse/HBASE-19400
> Project: HBase
> Issue Type: Sub-task
> Affects Versions: 2.0.0-beta-1
> Reporter: Balazs Meszaros
> Assignee: Appy
> Priority: Major
> Fix For: 2.0.0-beta-2
>
> Attachments: HBASE-19400.master.001.patch,
> HBASE-19400.master.002.patch, HBASE-19400.master.003.patch,
> HBASE-19400.master.004.patch, HBASE-19400.master.004.patch,
> HBASE-19400.master.005.patch
>
>
> The following RPC methods do not call the observers, therefore they are not
> guarded by AccessController:
> - normalize
> - setNormalizerRunning
> - runCatalogScan
> - enableCatalogJanitor
> - runCleanerChore
> - setCleanerChoreRunning
> - execMasterService
> - execProcedure
> - execProcedureWithRet
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
