[ 
https://issues.apache.org/jira/browse/HBASE-19978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16368708#comment-16368708
 ] 

stack commented on HBASE-19978:
-------------------------------

The test with 50 tables takes a while to run? You see the PE Workers swell up 
in number and then back down. Should there be any limit? 4x the passed in 
threads could be anything..... User could set it real small. We could run w/ a 
real small count but now you've added in keepalive, allow it swell to get over 
the hump so we don't do the deadlock?

+1 on commit if only for the nice refactor.

You think this all we need for the last failures?

Good stuff [~Apache9]

> The keepalive logic is incomplete in ProcedureExecutor
> ------------------------------------------------------
>
>                 Key: HBASE-19978
>                 URL: https://issues.apache.org/jira/browse/HBASE-19978
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: Duo Zhang
>            Assignee: Duo Zhang
>            Priority: Major
>             Fix For: 2.0.0-beta-2
>
>         Attachments: HBASE-19978-v1.patch, HBASE-19978.patch
>
>
> The worker thread will just exit after keep alive time, and we never add it 
> back. The only way to add it back is through the stuck checker, this is not 
> correct. Here we should start new worker thread if it is under the core pool 
> size and there are pending procedures.
> For now the default keep alive time is Long.MAX_VALUE which means no timeout 
> so no problem, but we do allow users to set it so we need to fix it.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to