[
https://issues.apache.org/jira/browse/HBASE-20020?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16370080#comment-16370080
]
stack commented on HBASE-20020:
-------------------------------
bq. I'm not familiar with the keep alive logic for master but since
MasterKeepAliveConnection is not deprecated so I still make use of it...
It is from a different time when Connection was managed under the covers and
Connections were shared across Tables/Admins in an effort at not making a
Connection on each query of the cluster. Now the Connection management has been
made the responsibility of the user, it doesn't make much sense anymore (that
said, we need to make it so users are not creating Connections every time but
that is another issue). IIRC, it was also about keeping up the zookeeper
Connection, another are that has changed fundamentally (with the
ReadOnlyZKClient).
On the patch...
This is good...
public class MasterNotRunningException extends HBaseIOException {
Thanks for purging these....
276 * @deprecated Since 0.96.0
277 */
278 @Deprecated
279 MasterKeepAliveConnection getKeepAliveMasterService()
The isDeadServer was deprecated in this commit which came in in hbase 0.99...
so removing the method in the patch is fine....
commit 74ab28497dee3f279f6dfef9f4661f1618df2c27
Author: sershe <sershe@unknown>
Date: Mon Feb 10 04:16:34 2014 +0000
HBASE-10479 HConnection interface is public but is used internally, and
contains a bunch of methods
git-svn-id: https://svn.apache.org/repos/asf/hbase/trunk@1566501
13f79535-47bb-0310-9956-ffa450edef68
Patch looks great. +1. It looks like it could make a big difference to client
responsiveness.
> Make sure we throw DoNotRetryIOException when ConnectionImplementation is
> closed
> --------------------------------------------------------------------------------
>
> Key: HBASE-20020
> URL: https://issues.apache.org/jira/browse/HBASE-20020
> Project: HBase
> Issue Type: Bug
> Components: Client
> Reporter: Duo Zhang
> Assignee: Duo Zhang
> Priority: Critical
> Fix For: 2.0.0-beta-2
>
> Attachments: HBASE-20020.patch
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
