[ 
https://issues.apache.org/jira/browse/HBASE-19735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16370548#comment-16370548
 ] 

Mike Drob commented on HBASE-19735:
-----------------------------------

There's some indentation changes in {{hbase-assembly/pom.xml}} that made me 
notice other issues. I'm happy with either dropping the indent fixes or moving 
the hbase-hadoop-compat exclusion on guava to top level pom.

{code:title= client-components.xml}
+    <!--Copy over the site if built as docs dir -->
+    <fileSet>
+      <directory>${project.basedir}/../target/site</directory>
+      <outputDirectory>docs</outputDirectory>
+    </fileSet>
{code}
Do we want/need this? Unsure if it's intentional or left over from a copy/paste 
from elsewhere.

{code:title=client.xml}
+  <!--This 'all' id is not appended to the produced bundle because we do this: 
http://maven.apache.org/plugins/maven-assembly-plugin/faq.html#required-classifiers
 -->
+  <id>client-bin</id>
{code}
id mismatch

{code:title=client.xml}
+              <exclude>com.sun.jersey:*</exclude>
+              <exclude>com.sun.jersey.contribs:*</exclude>
{code}
I'm not sure if this will work. The intent is correct, but MR jobs might fail 
without jersey, at least against hadoop 3. Been battling through some of the 
related issues on HBASE-19991.

What kind of testing have you done with the resulting artifact?

> Create a minimal "client" tarball installation
> ----------------------------------------------
>
>                 Key: HBASE-19735
>                 URL: https://issues.apache.org/jira/browse/HBASE-19735
>             Project: HBase
>          Issue Type: New Feature
>            Reporter: Josh Elser
>            Assignee: Josh Elser
>            Priority: Major
>             Fix For: 3.0.0
>
>         Attachments: HBASE-19735.000.patch, HBASE-19735.001.branch-2.patch, 
> HBASE-19735.002.branch-2.patch, HBASE-19735.003.patch, HBASE-19735.004.patch
>
>
> We're moving ourselves towards more controlled dependencies. A logical next 
> step is to try to do the same for our "binary" artifacts that we create 
> during releases.
> There is code (our's and our dependency's) which the HMaster and RegionServer 
> require which, obviously, clients do not need.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to