[
https://issues.apache.org/jira/browse/HBASE-19953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16370645#comment-16370645
]
stack commented on HBASE-19953:
-------------------------------
Sorry for the neglect [~elserj]. Its just that whenever I try to look at this
issue, I get an instant headache.
bq. The manifestation of this was Apache Atlas was getting audit events for
things that didn't actually happen which is no good.
Yes.
What you have done here is clean. Maybe some more comment to the effect that
the latch is just-for the Procedure preparation -- that we are not blocking for
the whole procedure run -- though the naming of the latch is enough I suppose.
That noop latch is 'interesting'...
+1 on commit.
> Avoid calling post* hook when procedure fails
> ---------------------------------------------
>
> Key: HBASE-19953
> URL: https://issues.apache.org/jira/browse/HBASE-19953
> Project: HBase
> Issue Type: Bug
> Components: master, proc-v2
> Reporter: Ramesh Mani
> Assignee: Josh Elser
> Priority: Critical
> Fix For: 2.0.0-beta-2
>
> Attachments: HBASE-19952.001.branch-2.patch,
> HBASE-19953.002.branch-2.patch, HBASE-19953.003.branch-2.patch
>
>
> Ramesh pointed out a case where I think we're mishandling some post\*
> MasterObserver hooks. Specifically, I'm looking at the deleteNamespace.
> We synchronously execute the DeleteNamespace procedure. When the user
> provides a namespace that isn't empty, the procedure does a rollback (which
> is just a no-op), but this doesn't propagate an exception up to the
> NonceProcedureRunnable in {{HMaster#deleteNamespace}}. It took Ramesh
> pointing it out a bit better to me that the code executes a bit differently
> than we actually expect.
> I think we need to double-check our post hooks and make sure we aren't
> invoking them when the procedure actually failed. cc/ [~Apache9], [~stack].
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
