Ted Yu commented on HBASE-19974:

Looks good overall.
+      // Only online but not decommissioned servers is real online
servers is real online -> servers are really online
+    List<ServerName> toDecommissionServers = new ArrayList<>();
toDecommissionServers -> serversToDecommission

See if there is better way than sleeping for a second (probably not).

> Decommissioned servers cannot be removed by remove_servers_rsgroup methods
> --------------------------------------------------------------------------
>                 Key: HBASE-19974
>                 URL: https://issues.apache.org/jira/browse/HBASE-19974
>             Project: HBase
>          Issue Type: Bug
>          Components: rsgroup
>    Affects Versions: 2.0.0-beta-2
>            Reporter: Xiaolin Ha
>            Assignee: Xiaolin Ha
>            Priority: Major
>         Attachments: HBASE-19974.branch-2.001.patch, 
> HBASE-19974.branch-2.002.patch, HBASE-19974.branch-2.003.patch
> When remove servers from a rsgroup, it will check the server is not online or 
> dead. But when we decommision a server, the server will be both in online 
> list and drainning list.

This message was sent by Atlassian JIRA

Reply via email to