Umesh Agashe commented on HBASE-20055:

Hi [~chia7712], agreed. Currently InterruptedException and 
ProcedureYieldException are treated same. I remember its documented here: 
 We also have in ProcedureExecutor.java:
private void handleInterruptedException(final Procedure proc, final 
InterruptedException e) {
  if (LOG.isTraceEnabled()) {
    LOG.trace("Interrupt during " + proc + ". suspend and retry it later.", e);

  // NOTE: We don't call Thread.currentThread().interrupt()
  // because otherwise all the subsequent calls e.g. Thread.sleep() will throw
  // the InterruptedException. If the master is going down, we will be notified
  // and the executor/store will be stopped.
  // (The interrupted procedure will be retried on the next run)
Currently none of the procedures throw it. So it can be removed.

> Remove declaration of un-thrown exceptions and unused 
> setRegionStateBackToOpen() from MergeTableRegionsProcedure
> ----------------------------------------------------------------------------------------------------------------
>                 Key: HBASE-20055
>                 URL: https://issues.apache.org/jira/browse/HBASE-20055
>             Project: HBase
>          Issue Type: Improvement
>          Components: amv2
>    Affects Versions: 2.0.0-beta-1
>            Reporter: Umesh Agashe
>            Assignee: Umesh Agashe
>            Priority: Minor
>             Fix For: 2.0.0-beta-2
>         Attachments: hbase-20055.master.001.patch
> A few methods declare exceptions in throws statement that are not thrown and 
> method setRegionStateBackToOpen() is not used in MergeTableRegionsProcedure.

This message was sent by Atlassian JIRA

Reply via email to