[ 
https://issues.apache.org/jira/browse/HBASE-20052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16375180#comment-16375180
 ] 

Appy commented on HBASE-20052:
------------------------------

Don't have any context here, so my question might not be right, but here goes..
bq. HRegionFileSystem#createRegionOnFileSystem() should always return the 
instance of HRegionFileSystem (even if .regioninfo file is not created)
Why so?
I don't see it's return value being used anywhere except here: 
https://github.com/apache/hbase/blob/master/hbase-server/src/main/java/org/apache/hadoop/hbase/snapshot/SnapshotManifestV1.java#L80,
 and i think that snapshot may have nothing to do with replicas? If so, 
please revert the change in prod code and rather fix the test.

> TestRegionOpen#testNonExistentRegionReplica fails due to NPE
> ------------------------------------------------------------
>
>                 Key: HBASE-20052
>                 URL: https://issues.apache.org/jira/browse/HBASE-20052
>             Project: HBase
>          Issue Type: Test
>            Reporter: Ted Yu
>            Assignee: Ted Yu
>            Priority: Major
>             Fix For: 1.5.0, 2.0.0-beta-2, 1.4.3
>
>         Attachments: 20052.v1.txt, 20052.v2.txt
>
>
> After HBASE-19391 was integrated, the following test failure can be observed:
> {code}
> java.lang.NullPointerException
>       at 
> org.apache.hadoop.hbase.regionserver.TestRegionOpen.testNonExistentRegionReplica(TestRegionOpen.java:122)
> {code}
> This was due null being returned from 
> HRegionFileSystem#createRegionOnFileSystem().



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to