[
https://issues.apache.org/jira/browse/HBASE-20061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16375642#comment-16375642
]
Sean Busbey commented on HBASE-20061:
-------------------------------------
{code}
-1 hadoopcheck 6m 7s The patch causes 10 errors with Hadoop v2.6.5.
-1 hadoopcheck 8m 3s The patch causes 10 errors with Hadoop v2.7.4.
-1 hadoopcheck 10m 10s The patch causes 10 errors with Hadoop v3.0.0.
{code}
they're all:
{code}
[ERROR] Failed to execute goal
org.apache.maven.plugins:maven-install-plugin:2.5.2:install (default-install)
on project hbase-thrift: Failed to install metadata
org.apache.hbase:hbase-thrift:3.0.0-SNAPSHOT/maven-metadata.xml: Could not
parse metadata
/home/jenkins/.m2/repository/org/apache/hbase/hbase-thrift/3.0.0-SNAPSHOT/maven-metadata-local.xml:
in epilog non whitespace content is not allowed but got / (position: END_TAG
seen ...</metadata>\n/... @25:2) -> [Help 1]
{code}
output looks like local maven repo corruption. and that maven repo looks like
the jenkins user repo instead of the per-build repo that we should be using for
precommit. filed HBASE-20068.
{code}
-1 findbugs 1m 50s hbase-server in master has 24 extant Findbugs
warnings.
{code}
This is the problem caused by us running blind for awhile. either HBASE-15151
or HBASE-20069 will fix this. the warnings aren't in the part of the code this
patch is already dealing with.
{code}
-1 test4tests 0m 0s The patch doesn't appear to include any new or
modified tests. Please justify why no new tests are needed for this patch. Also
please list what manual steps were performed to verify this patch.
{code}
Any test for "is this member variable private" is going to be overkill, IMHO.
[~chia7712] you okay with my reasoning for the above?
> HStore synchronized member variable filesCompacting should be private
> ---------------------------------------------------------------------
>
> Key: HBASE-20061
> URL: https://issues.apache.org/jira/browse/HBASE-20061
> Project: HBase
> Issue Type: Bug
> Components: regionserver
> Affects Versions: 1.2.0, 3.0.0, 1.3.0, 1.4.0, 1.5.0, 2.0.0-alpha-1
> Reporter: Sean Busbey
> Assignee: Sean Busbey
> Priority: Major
> Fix For: 2.0.0, 3.0.0, 1.3.2, 1.5.0, 1.2.7, 1.4.3
>
> Attachments: HBASE-20061.0.patch
>
>
> follow up to HBASE-19728 (which is in an RC for 1.4.2 currently, so no
> addendums):
> the filesCompacting member is currently package private, which allows folks
> outside of HStore to modify it without ensuring we have hte needed locking in
> place. it looks like we don't actually use it anywhere outside of HStore, so
> we should just make it private.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
