[
https://issues.apache.org/jira/browse/HBASE-20047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16375882#comment-16375882
]
Sean Busbey commented on HBASE-20047:
-------------------------------------
{code}
-1 test4tests 0m 0s The patch doesn't appear to include any new or
modified tests. Please justify why no new tests are needed for this patch. Also
please list what manual steps were performed to verify this patch.
{code}
I don't think any tests are needed for a newly added toString method, since I
don't think we want to make any assertions about the format returned string for
the future. I would like to see that someone spins up an instance with this
change in place to show what the updated log message looks like before we
commit the change.
> AuthenticationTokenIdentifier should provide a toString
> -------------------------------------------------------
>
> Key: HBASE-20047
> URL: https://issues.apache.org/jira/browse/HBASE-20047
> Project: HBase
> Issue Type: Improvement
> Components: Usability
> Reporter: Sean Busbey
> Assignee: maoling
> Priority: Minor
> Labels: beginner
> Attachments: HBASE-20047.master.v0.patch
>
>
> It'd be easier to debug things like MapReduce and Spark jobs if our
> AuthenticationTokenIdentifier provided a toString method.
> For comparison, here's an example of a MapReduce job that has both an HDFS
> delegation token and our delegation token:
> {code:java}
> 18/02/21 20:40:06 INFO mapreduce.JobSubmitter: Kind: HBASE_AUTH_TOKEN,
> Service: 92a63bd8-9e00-4c04-ab61-da8e606068e1, Ident:
> (org.apache.hadoop.hbase.security.token.AuthenticationTokenIdentifier@17)
> 18/02/21 20:40:06 INFO mapreduce.JobSubmitter: Kind: HDFS_DELEGATION_TOKEN,
> Service: 172.31.118.118:8020, Ident: (token for some_user:
> HDFS_DELEGATION_TOKEN owner=some_u...@example.com, renewer=yarn, realUser=,
> issueDate=1519274405003, maxDate=1519879205003, sequenceNumber=23,
> masterKeyId=9)
> {code}
> Stuff in TokenIdentifier is supposed to be public, so we should be fine to
> dump everything, similar to Hadoop's AbstractDelegationTokenIdentifier.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
