[
https://issues.apache.org/jira/browse/HBASE-20069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16377820#comment-16377820
]
Chia-Ping Tsai commented on HBASE-20069:
----------------------------------------
{quote}We cannot have WakeupFlushThread be anonymous as whole point of its
existence is being able to identify this explicit signaling class.
{quote}
We don't use the instance check anymore, so it is ok to remove the
WakeupFlushThread. The "==" work well even if we use anonymous class.
{code:java}
- if (fqe == null || fqe instanceof WakeupFlushThread) {
+ if (fqe == null || fqe == WAKEUPFLUSH_INSTANCE) {{code}
{quote}Any +1s?
{quote}
Pardon me. I just wake up. +1
> fix existing findbugs errors in hbase-server
> --------------------------------------------
>
> Key: HBASE-20069
> URL: https://issues.apache.org/jira/browse/HBASE-20069
> Project: HBase
> Issue Type: Sub-task
> Components: findbugs
> Reporter: Sean Busbey
> Assignee: stack
> Priority: Critical
> Fix For: 2.0.0-beta-2
>
> Attachments: FindBugs Report.htm, HBASE-20069.branch-2.001.patch,
> HBASE-20069.branch-2.002.patch, HBASE-20069.branch-2.003.patch,
> HBASE-20069.branch-2.004.patch
>
>
> now that findbugs is running on precommit we have some cleanup to do.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
