[
https://issues.apache.org/jira/browse/HBASE-18309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16377826#comment-16377826
]
stack commented on HBASE-18309:
-------------------------------
[~reidchan] You up for taking a look again at how CleanerChore does its
single-instance pool? Findbugs was off for a while and when we reenabled it, it
'lit up" around this bit of code. I hacked on it, probably made it worse
(HBASE-20069), but it passes findbugs now (smile).
First suggestion was a lazy singleton ... but maybe that won't work because of
onChangeConfiguration... where you want to support changing pool. Another
suggestion at https://reviews.apache.org/r/65794/#comment278374 is that rather
than CleanerChore hosting the pool, instead we'd pass in the pool. This might
be tough-to-do for same reason in that what happens onChangeConfiguration....
Do all instances change the pool....
Anyways, would be interested in your thoughts. We could do it in a new issue?
Thanks.
> Support multi threads in CleanerChore
> -------------------------------------
>
> Key: HBASE-18309
> URL: https://issues.apache.org/jira/browse/HBASE-18309
> Project: HBase
> Issue Type: Improvement
> Reporter: binlijin
> Assignee: Reid Chan
> Priority: Major
> Fix For: 3.0.0, 2.0.0-beta-1
>
> Attachments: HBASE-18309.addendum.patch,
> HBASE-18309.master.001.patch, HBASE-18309.master.002.patch,
> HBASE-18309.master.004.patch, HBASE-18309.master.005.patch,
> HBASE-18309.master.006.patch, HBASE-18309.master.007.patch,
> HBASE-18309.master.008.patch, HBASE-18309.master.009.patch,
> HBASE-18309.master.010.patch, HBASE-18309.master.011.patch,
> HBASE-18309.master.012.patch, space_consumption_in_archive.png
>
>
> There is only one thread in LogCleaner to clean oldWALs and in our big
> cluster we find this is not enough. The number of files under oldWALs reach
> the max-directory-items limit of HDFS and cause region server crash, so we
> use multi threads for LogCleaner and the crash not happened any more.
> What's more, currently there's only one thread iterating the archive
> directory, and we could use multiple threads cleaning sub directories in
> parallel to speed it up.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
