[
https://issues.apache.org/jira/browse/HBASE-20097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16378873#comment-16378873
]
Ted Yu commented on HBASE-20097:
--------------------------------
lgtm
> Merge TableDescriptors#getAll and TableDescriptors#getAllDescriptors into one
> -----------------------------------------------------------------------------
>
> Key: HBASE-20097
> URL: https://issues.apache.org/jira/browse/HBASE-20097
> Project: HBase
> Issue Type: Task
> Reporter: Chia-Ping Tsai
> Assignee: Chia-Ping Tsai
> Priority: Minor
> Fix For: 2.0.0
>
> Attachments: HBASE-20097.v0.patch
>
>
> {code:java}
> @Override
> public Map<String, TableDescriptor> getAll() throws IOException {
> Map<String, TableDescriptor> htds = new TreeMap<>();
> Map<String, TableDescriptor> allDescriptors = getAllDescriptors();
> for (Map.Entry<String, TableDescriptor> entry : allDescriptors
> .entrySet()) {
> htds.put(entry.getKey(), entry.getValue());
> }
> return htds;
> }{code}
> The returned map from #getAllDescriptors isn't a inner object so doing the
> clone is meaningless.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
