[ 
https://issues.apache.org/jira/browse/HBASE-20108?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16382468#comment-16382468
 ] 

Josh Elser commented on HBASE-20108:
------------------------------------

{quote}Testing against h2 and h3? I suspect there's no difference, and don't 
need it before commit, but a statement on what you've done would be good.
{quote}
Yup, just tested H3. No issues (as expected).
{quote}Do we need to update hbase.cmd? Maybe a follow on issue for discussing 
the level of support that it needs?
{quote}
Looks like it, but I don't know how to test that one. Since Stack has asked for 
silence on branch-2, I'll put up a new patch with some copy-paste from 
elsewhere in hbase.cmd which I think will work.

> `hbase zkcli` falls into a non-interactive prompt after HBASE-15199
> -------------------------------------------------------------------
>
>                 Key: HBASE-20108
>                 URL: https://issues.apache.org/jira/browse/HBASE-20108
>             Project: HBase
>          Issue Type: Bug
>          Components: Usability
>            Reporter: Josh Elser
>            Assignee: Josh Elser
>            Priority: Critical
>             Fix For: 2.0.0-beta-2
>
>         Attachments: HBASE-20108.001.branch-2.patch, 
> HBASE-20108.002.branch-2.patch, HBASE-20108.003.branch-2.patch
>
>
> HBASE-15199 pulls the jruby-complete jar out of the normal classpath for 
> commands run in HBase. Jruby-complete bundles jline inside. ZK uses jline for 
> its nice shell-like usage.
> The problem is that this uncovered a bug where we're not explicitly bundling 
> a version of jline to make sure that {{hbase zkcli}} actually works. As long 
> as we're expecting {{zkcli}} to be there, we should provide jline on the 
> classpath to make sure the users get a real cli.
> Thanks to [~sergey.soldatov] for getting to the bottom of it quickly.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to