[
https://issues.apache.org/jira/browse/HBASE-20121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16386824#comment-16386824
]
Vladimir Rodionov commented on HBASE-20121:
-------------------------------------------
{code}
So the behavior of incremental and non-incremental restore ends up being the
same?
{code}
That was an old code artefact, which has skipped numerous code reviews. Should
be removed. Completely. Including this:
{code}
if (image.getType() == BackupType.INCREMENTAL) {
backupIdSet.add(image.getBackupId());
LOG.debug("adding " + image.getBackupId() + " for bulk load");
}
{code}
> Fix findbugs warning for RestoreTablesClient
> --------------------------------------------
>
> Key: HBASE-20121
> URL: https://issues.apache.org/jira/browse/HBASE-20121
> Project: HBase
> Issue Type: Bug
> Affects Versions: 3.0.0
> Reporter: Ted Yu
> Assignee: Ted Yu
> Priority: Minor
> Labels: backup
> Attachments: 20121.v1.txt
>
>
> In RestoreTablesClient#restore(), the following variable is not used:
> {code}
> Set<String> backupIdSet = new HashSet<>();
> {code}
> There is backupIdSet#add() call later in the method but the variable doesn't
> appear in any other part of the code.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
