Josh Elser commented on HBASE-20136:

{quote}Seems the problem is that, there is no small|medium|large category for 
this class so in the pre commit or nightly build processing we never run it... 
We will first run SmallTests, and then MediumTests and LargeTests.
I guess that means we need to check out all of the tests and nuke any that 
aren't junit4-style? Shouldn't be bad in an IDE, I guess. We should make sure a 
follow-on gets filed.

Why did HBaseClassTestRuleChecker not find this?

Why does the build not fail?

[~yuzhih...@gmail.com], the spirit of this question was "how did this get 
committed without QA failing", less about how was the failure triggered. I'm 
99% positive Stack was more curious about how the failure was introduced and 
related worry about our checks being ineffective (as Duo did then find to be 
the case).

> TestKeyValue misses ClassRule and Category annotations
> ------------------------------------------------------
>                 Key: HBASE-20136
>                 URL: https://issues.apache.org/jira/browse/HBASE-20136
>             Project: HBase
>          Issue Type: Test
>            Reporter: Ted Yu
>            Assignee: Ted Yu
>            Priority: Minor
>              Labels: CE
>         Attachments: 20136.v1.txt, 20136.v2.txt
> hbase-common/src/test/java/org/apache/hadoop/hbase/TestKeyValue.java misses 
> ClassRule and Category annotations.
> This issue adds the annotations to this test.

This message was sent by Atlassian JIRA

Reply via email to