[
https://issues.apache.org/jira/browse/HBASE-20133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16389682#comment-16389682
]
Xiang Li commented on HBASE-20133:
----------------------------------
Thanks [[email protected]] for the comments!
1. Regarding
bq. BTW why is this JIRA critical ? The change is just some refactoring.
Sorry. Change it into "Minor"
2. Regarding
bq. Have you considered using tuple as return value ? It seems to be clearer
that way.
Almost got your idea. But does Java support tuple? I think it needs to
implement a simple tuple class or use a third-party library, like
org.apache.commons.lang3.tuple.Pair? Do you mean to do it that way? Just wonder
if it worths it (use only once for a return of a function)
Please correct me if I get it wrong.
> Calculate correct assignment and build region movement plans for mis-placed
> regions in one pass
> -----------------------------------------------------------------------------------------------
>
> Key: HBASE-20133
> URL: https://issues.apache.org/jira/browse/HBASE-20133
> Project: HBase
> Issue Type: Improvement
> Components: rsgroup
> Reporter: Xiang Li
> Assignee: Xiang Li
> Priority: Minor
> Attachments: HBASE-20133.master.000.patch
>
>
> In RSGroupBasedLoadBalancer#balanceCluster(clusterState), the logic could be
> improved:
> correctAssignment() builds a map for mis-placed and placed regions. For
> mis-placed regions, the key(ServerName) is BOGUS_SERVER_NAME. Then the logic
> gets those mis-paced regions out and calls findServerForRegion() several
> times to find out the current host server, in order to build RegionPlan for
> movement.
> Some logic in correctAssignment() and findServerForRegion() could be merged
> so as to build both corrected assignment and RegionPlan for mis-placed region
> in one pass. As a result, findServerForRegion() could be removed if I get it
> correctly.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
