[
https://issues.apache.org/jira/browse/HBASE-20095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16391188#comment-16391188
]
Reid Chan commented on HBASE-20095:
-----------------------------------
Checked the period between chore is 10 minutes for both {{LogCleaner}} and
{{HFileCleaner}}, the max allowed is 15 minutes.
bq. Yea, there is risk that we are overworking a solution here.
bq. Taking a step back... why not interrupt immediately? So we have extra files
that stay around for another cycle... It's a scheduled chore, so it will try
again shortly, doesn't seem like a huge problem.
Agree~.
v9 doesn't shutdown immediately, but wait 0.8 * period (8 minutes in default
case). If other cleaners are still working after timeout, the first finished
cleaner would shutdown the pool.
This makes use of the still time between chores and gives chance to updating
pool successfully, at least not to leave too much files to next cycle.
> Redesign single instance pool in CleanerChore
> ---------------------------------------------
>
> Key: HBASE-20095
> URL: https://issues.apache.org/jira/browse/HBASE-20095
> Project: HBase
> Issue Type: Improvement
> Reporter: Reid Chan
> Assignee: Reid Chan
> Priority: Critical
> Attachments: HBASE-20095.master.001.patch,
> HBASE-20095.master.002.patch, HBASE-20095.master.003.patch,
> HBASE-20095.master.004.patch, HBASE-20095.master.005.patch,
> HBASE-20095.master.006.patch, HBASE-20095.master.007.patch,
> HBASE-20095.master.008.patch, HBASE-20095.master.009.patch
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
