[
https://issues.apache.org/jira/browse/HBASE-20167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16394447#comment-16394447
]
Duo Zhang commented on HBASE-20167:
-----------------------------------
OK, this is a refactoring so no new tests, others are all green. Any concerns?
[~zghaobac] [~openinx]? I think this patch can make our code much cleaner.
Thanks.
> Optimize the implementation of ReplicationSourceWALReader
> ---------------------------------------------------------
>
> Key: HBASE-20167
> URL: https://issues.apache.org/jira/browse/HBASE-20167
> Project: HBase
> Issue Type: Sub-task
> Components: Replication
> Reporter: Duo Zhang
> Assignee: Duo Zhang
> Priority: Major
> Fix For: 3.0.0
>
> Attachments: HBASE-20167-v1.patch, HBASE-20167.patch
>
>
> After HBASE-20148, serial replication will be an option for peer. Since an
> instance of ReplicationSourceWALReader can only belongs to one peer, we do
> not need to add the so many 'if' in the implementation of readWALEntries to
> check whether we should consider serial replication. We can just make a sub
> class or something similiar for serial replication to make the code clean.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
