[
https://issues.apache.org/jira/browse/HBASE-20165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16396670#comment-16396670
]
Zheng Hu commented on HBASE-20165:
----------------------------------
{code}
/testptch/hbase/hbase-shell/src/main/ruby/hbase/replication_admin.rb:31:3: C:
Metrics/ClassLength: Class has too many lines. [267/100]
/testptch/hbase/hbase-shell/src/main/ruby/hbase/replication_admin.rb:291:9: C:
Layout/MultilineMethodCallIndentation: Align `.newBuilder` with `.apache` on
line 290.
/testptch/hbase/hbase-shell/src/main/ruby/hbase/replication_admin.rb:374:9: C:
Layout/MultilineMethodCallIndentation: Align `.newBuilder` with `.apache` on
line 373.
/testptch/hbase/hbase-shell/src/main/ruby/shell/commands/list_peers.rb:38:7: C:
Metrics/AbcSize: Assignment Branch Condition size for command is too high.
[27.28/15]
/testptch/hbase/hbase-shell/src/main/ruby/shell/commands/list_peers.rb:42:81:
C: Metrics/LineLength: Line is too long. [87/80]
/testptch/hbase/hbase-shell/src/main/ruby/shell/commands/set_peer_serial.rb:23:5:
C: Style/Documentation: Missing top-level class documentation comment.
/testptch/hbase/hbase-shell/src/main/ruby/shell/commands/set_peer_serial.rb:41:1:
C: Naming/HeredocDelimiterNaming: Use meaningful heredoc delimiters.
/testptch/hbase/hbase-shell/src/test/ruby/hbase/replication_admin_test.rb:28:3:
C: Metrics/ClassLength: Class has too many lines. [402/100]
{code}
Will fix rubocop when commiting, Any other concerns ?
{code}
/testptch/hbase/hbase-shell/src/main/ruby/hbase/replication_admin.rb:291:9: C:
Layout/MultilineMethodCallIndentation: Align `.newBuilder` with `.apache` on
line 290.
/testptch/hbase/hbase-shell/src/main/ruby/hbase/replication_admin.rb:374:9: C:
Layout/MultilineMethodCallIndentation: Align `.newBuilder` with `.apache` on
line 373.
/testptch/hbase/hbase-shell/src/main/ruby/shell/commands/list_peers.rb:42:81:
C: Metrics/LineLength: Line is too long. [87/80]
{code}
> Shell command to make a normal peer to be a serial replication peer
> -------------------------------------------------------------------
>
> Key: HBASE-20165
> URL: https://issues.apache.org/jira/browse/HBASE-20165
> Project: HBase
> Issue Type: Sub-task
> Reporter: Zheng Hu
> Assignee: Zheng Hu
> Priority: Major
> Attachments: HBASE-20165.v1.patch, HBASE-20165.v2.patch
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
