[
https://issues.apache.org/jira/browse/HBASE-5388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13206563#comment-13206563
]
Lars Hofhansl commented on HBASE-5388:
--------------------------------------
NavigableMap has lowerKey and lowerEntry, we should use the same naming scheme.
(Ideally SoftValueSortedMap should implement NavigableMap. But that is a
different story.)
This whole block:
{code}
SortedMap<byte[], HRegionLocation> matchingRegions =
tableLocations.headMap(row);
// if that portion of the map is empty, then we're done. otherwise,
// we need to examine the cached location to verify that it is
// a match by end key as well.
if (!matchingRegions.isEmpty()) {
HRegionLocation possibleRegion = null;
try {
possibleRegion = matchingRegions.get(matchingRegions.lastKey());
{code}
is essentially equivalent to
{code}
possibleRegion = tableLocations.lowerEntry(row).getValue()
{code}
@ronghai: I'm happy to make a patch.
> Tuning HConnectionManager#getCachedLocation method
> --------------------------------------------------
>
> Key: HBASE-5388
> URL: https://issues.apache.org/jira/browse/HBASE-5388
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.90.5
> Reporter: ronghai.ma
> Assignee: ronghai.ma
> Labels: patch
> Fix For: 0.94.0
>
>
> About 75% improvement in execution time.
> 1. Add the following method in SoftValueSortedMap:
> {code}
> public synchronized <K, V> Entry<K, V> lowerEntry(K key) {
> return ((TreeMap) this.internalMap).lowerEntry(key);
> }
> {code}
> 2. Modify getCachedLocation:
> {code}
> Map.Entry<byte[], HRegionLocation> tEntry = tableLocations.lowerEntry(row);
> if (tEntry != null) {
> HRegionLocation possibleRegion = tEntry.getValue();
> //other code
> }
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
