[
https://issues.apache.org/jira/browse/HBASE-5388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13206674#comment-13206674
]
Lars Hofhansl commented on HBASE-5388:
--------------------------------------
Not too fond of this part:
{code}
- SortedMap<byte [], HRegionLocation> tableLocations =
- getTableLocations(tableName);
+ SoftValueSortedMap<byte [], HRegionLocation> tableLocations =
+ (SoftValueSortedMap) getTableLocations(tableName);
{code}
I did a patch earlier that removed all concrete references to
SoftValueSortedMap, except for creation... This would be a step back.
Maybe SoftValueSortedMap should implement NavigableMap and just throw
UnsupportedOperation on all other new methods, in that case SoftValueSortedMap
could implement lowerEntry.
... Or maybe this would be overkill.
> Tuning HConnectionManager#getCachedLocation method
> --------------------------------------------------
>
> Key: HBASE-5388
> URL: https://issues.apache.org/jira/browse/HBASE-5388
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.90.5
> Reporter: ronghai.ma
> Assignee: ronghai.ma
> Labels: patch
> Fix For: 0.94.0
>
> Attachments: 5388-v2.txt, HConnectionManager.java,
> SoftValueSortedMap.java, SoftValueSortedMap.java
>
>
> About 75% improvement in execution time.
> 1. Add the following method in SoftValueSortedMap:
> {code}
> public synchronized <K, V> Entry<K, V> lowerEntry(K key) {
> return ((TreeMap) this.internalMap).lowerEntry(key);
> }
> {code}
> 2. Modify getCachedLocation:
> {code}
> Map.Entry<byte[], HRegionLocation> tEntry = tableLocations.lowerEntry(row);
> if (tEntry != null) {
> HRegionLocation possibleRegion = tEntry.getValue();
> //other code
> }
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
