Appy commented on HBASE-20181:

[~yuzhih...@gmail.com] reason i committed it was, his style is doing one file 
at a time.

[~belugabehr] Ted's feedback here, and i support it is, at some point you need 
to grow - in size, skill, etc. One simple way here is, do piece-wise work, 
saving it in small git commits (squash them as needed, ++ git-fu skills) and 
scale up until you are comfortable to modify whole modules at a time :)

> Logging and minor logic improvements in BackupLogCleaner
> --------------------------------------------------------
>                 Key: HBASE-20181
>                 URL: https://issues.apache.org/jira/browse/HBASE-20181
>             Project: HBase
>          Issue Type: Improvement
>          Components: hbase
>    Affects Versions: 2.0.0
>            Reporter: BELUGA BEHR
>            Assignee: BELUGA BEHR
>            Priority: Trivial
>         Attachments: HBASE-20181.1.patch
> # Simplify code
>  # Use re-usable libraries
>  # Use SLF4J parameter logging format
>  # Clean up some log messages

This message was sent by Atlassian JIRA

Reply via email to