[ 
https://issues.apache.org/jira/browse/HBASE-20220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16404962#comment-16404962
 ] 

Ted Yu commented on HBASE-20220:
--------------------------------

testNotExistTableMove -> testNonExistentTableMove
{code}
+          if strs.size == 1
+            raise "Unknown table #{strs[0]}!"
{code}
What if the exception changes in the future ? Would "Unknown table" always 
apply ?

Please see if the rubocop warnings were related to the patch.

> [RSGroup] Check if table exists in the cluster before moving it to the 
> specified regionserver group
> ---------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-20220
>                 URL: https://issues.apache.org/jira/browse/HBASE-20220
>             Project: HBase
>          Issue Type: Bug
>          Components: rsgroup
>    Affects Versions: 3.0.0
>            Reporter: Guangxu Cheng
>            Assignee: Guangxu Cheng
>            Priority: Major
>         Attachments: HBASE-20220.master.001.patch
>
>
> move_tables_rsgroup/move_servers_tables_rsgroup can move non-existent tables 
> in the cluster to the specified regionserver group successfully.It's not 
> reasonable.We should check whether the table has already existed in the 
> cluster before moving the table.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to