[
https://issues.apache.org/jira/browse/HBASE-5388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13207338#comment-13207338
]
Lars Hofhansl commented on HBASE-5388:
--------------------------------------
@Ted: v3
I'd probably keep the name of possibleRegion (rather than rl), also keep this
comment
{code}
- // make sure that the end key is greater than the row we're looking
- // for, otherwise the row actually belongs in the next region, not
- // this one. the exception case is when the endkey is
- // HConstants.EMPTY_START_ROW, signifying that the region we're
- // checking is actually the last region in the table.
{code}
which is still valid.
Also is this needed:
{code}
+ if (value.get() == null) {
+ this.internalMap.remove(key);
+ return null;
+ }
{code}
? That is what checkReferences will do on the next access anyway, right?
> Tuning HConnectionManager#getCachedLocation method
> --------------------------------------------------
>
> Key: HBASE-5388
> URL: https://issues.apache.org/jira/browse/HBASE-5388
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.90.5
> Reporter: ronghai.ma
> Assignee: ronghai.ma
> Labels: patch
> Fix For: 0.94.0
>
> Attachments: 5388-v2.txt, 5388-v3.txt, HConnectionManager.java,
> SoftValueSortedMap.java, SoftValueSortedMap.java
>
>
> About 75% improvement in execution time.
> 1. Add the following method in SoftValueSortedMap:
> {code}
> public synchronized <K, V> Entry<K, V> lowerEntry(K key) {
> return ((TreeMap) this.internalMap).lowerEntry(key);
> }
> {code}
> 2. Modify getCachedLocation:
> {code}
> Map.Entry<byte[], HRegionLocation> tEntry = tableLocations.lowerEntry(row);
> if (tEntry != null) {
> HRegionLocation possibleRegion = tEntry.getValue();
> //other code
> }
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
