[ 
https://issues.apache.org/jira/browse/HBASE-20269?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ted Yu updated HBASE-20269:
---------------------------
    Description: 
In ZKReplicationQueueStorage#setWALPosition :
{code}
      addLastSeqIdsToOps(queueId, lastSeqIds, listOfOps);
      ZKUtil.multiOrSequential(zookeeper, listOfOps, false);
{code}
If there is no ZKUtilOp in listOfOps, the call to ZKUtil#multiOrSequential 
should be skipped.

  was:
The following test failure is reproducible in master branch:
{code}
testRegionReplicaReplicationIgnoresDroppedTables(org.apache.hadoop.hbase.replication.regionserver.TestRegionReplicaReplicationEndpoint)
  Time elapsed: 21.493 sec  <<< FAILURE!
java.lang.AssertionError
  at 
org.apache.hadoop.hbase.replication.regionserver.TestRegionReplicaReplicationEndpoint.verifyReplication(TestRegionReplicaReplicationEndpoint.java:260)
  at 
org.apache.hadoop.hbase.replication.regionserver.TestRegionReplicaReplicationEndpoint.verifyReplication(TestRegionReplicaReplicationEndpoint.java:243)
  at 
org.apache.hadoop.hbase.replication.regionserver.TestRegionReplicaReplicationEndpoint.testRegionReplicaReplicationIgnoresDisabledTables(TestRegionReplicaReplicationEndpoint.java:439)
  at 
org.apache.hadoop.hbase.replication.regionserver.TestRegionReplicaReplicationEndpoint.testRegionReplicaReplicationIgnoresDroppedTables(TestRegionReplicaReplicationEndpoint.java:372)
{code}
In ZKReplicationQueueStorage#setWALPosition :
{code}
      addLastSeqIdsToOps(queueId, lastSeqIds, listOfOps);
      ZKUtil.multiOrSequential(zookeeper, listOfOps, false);
{code}
If there is no ZKUtilOp in listOfOps, the call to ZKUtil#multiOrSequential 
should be skipped.


> ZKReplicationQueueStorage#setWALPosition should only call 
> ZKUtil#multiOrSequential when there is at least one ZKUtilOp
> ----------------------------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-20269
>                 URL: https://issues.apache.org/jira/browse/HBASE-20269
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Ted Yu
>            Assignee: Ted Yu
>            Priority: Major
>         Attachments: 20269.v1.txt
>
>
> In ZKReplicationQueueStorage#setWALPosition :
> {code}
>       addLastSeqIdsToOps(queueId, lastSeqIds, listOfOps);
>       ZKUtil.multiOrSequential(zookeeper, listOfOps, false);
> {code}
> If there is no ZKUtilOp in listOfOps, the call to ZKUtil#multiOrSequential 
> should be skipped.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to